Adding new data sources to cloudstack-terraform-proivder#38
Conversation
| }, | ||
| }) | ||
| } | ||
|
|
There was a problem hiding this comment.
❯ TF_ACC=1 go test -run TestAccSshKeyPairDataSource_basic -v
=== RUN TestAccSshKeyPairDataSource_basic
--- PASS: TestAccSshKeyPairDataSource_basic (0.21s)
PASS
ok github.com/terraform-providers/terraform-provider-cloudstack/cloudstack 0.217s
| }, | ||
| }) | ||
| } | ||
|
|
There was a problem hiding this comment.
❯ TF_ACC=1 go test -run TestAccNetworkOfferingDataSource_basic -v
=== RUN TestAccNetworkOfferingDataSource_basic
--- PASS: TestAccNetworkOfferingDataSource_basic (0.26s)
PASS
ok
| }, | ||
| }) | ||
| } | ||
|
|
There was a problem hiding this comment.
❯ TF_ACC=1 go test -run TestAccZoneDataSource_basic -v
=== RUN TestAccZoneDataSource_basic
--- PASS: TestAccZoneDataSource_basic (0.29s)
PASS
ok github.com/terraform-providers/terraform-provider-cloudstack/cloudstack 0.302s
| }, | ||
| }) | ||
| } | ||
|
|
There was a problem hiding this comment.
❯ TF_ACC=1 go test -run TestAccNetworkOfferingDataSource_basic -v
=== RUN TestAccNetworkOfferingDataSource_basic
--- PASS: TestAccNetworkOfferingDataSource_basic (0.27s)
PASS
ok github.com/terraform-providers/terraform-provider-cloudstack/cloudstack 0.273s
Damans227
force-pushed
the
AddNewDataSources
branch
from
d4fc87d to
5015e80
Compare
| }, | ||
| }) | ||
| } | ||
|
|
There was a problem hiding this comment.
❯ TF_ACC=1 go test -run TestAccVPCDataSource_basic -v
=== RUN TestAccVPCDataSource_basic
--- PASS: TestAccVPCDataSource_basic (31.61s)
PASS
ok github.com/terraform-providers/terraform-provider-cloudstack/cloudstack 31.617s
| }, | ||
| }) | ||
| } | ||
|
|
There was a problem hiding this comment.
❯ TF_ACC=1 go test -run TestAccIPAddressDataSource_basic -v
=== RUN TestAccIPAddressDataSource_basic
--- PASS: TestAccIPAddressDataSource_basic (2.38s)
PASS
ok github.com/terraform-providers/terraform-provider-cloudstack/cloudstack 2.390s
| }, | ||
| }) | ||
| } | ||
|
|
There was a problem hiding this comment.
❯ TF_ACC=1 go test -run TestAccUserDataSource_basic -v
=== RUN TestAccUserDataSource_basic
--- PASS: TestAccUserDataSource_basic (0.34s)
PASS
ok github.com/terraform-providers/terraform-provider-cloudstack/cloudstack 0.349s
|
Hi @Damans227 can you advise if this is ready for review and testing or you're still working on it? |
Hello @rohityadavcloud, this PR is ready to be reviewed and tested as per the timeline agreed upon in my GSoC proposal. I am actually ahead of schedule because after the final evaluation, I am supposed to request an extension to add new resources and corresponding data sources, which I have already begun. Looping in @Pearl1594 and @harikrishna-patnala. Lemme know what do you think. |
I believe it would be best to finalize this PR and then work on the extended scope of the project in a separate PR after final evaluation. Let me know what you think. |
|
Thanks for the update @Damans227 |
kiranchavala
left a comment
kiranchavala
left a comment
There was a problem hiding this comment.
LGTM , tested all the data sources manually and its working fine
|
Thanks for the review and merge, @kiranchavala @rohityadavcloud |
* create ssh keypair data-source * create a method stub for instance data-source * extending instance data-source to use its id as an input * use SetId() to define the ID of the instance resource * implement filters to allow filtering off of any exported attributes * add ip-address to schema and allow filtering off of it * create a method stub to acceptance test the instance data-source * basic acceptance test for instance data-source passing * adding comments to improve the readability of code * add basic acceptance test for ssh keypair data-source * create network offering resource * complete network offering resource type * create network offering data source * add basic acceptance test for network offering data source * create disk offering resource * implement create method for disk offering resource * create cloudstack volume resource type * create cloudstack zone resource type * create zone data source * add acceptance test for zone datasource * create service offering resource * create service offering data source * add service offering data source * fix typos in comments for network offering resource * add volume data source * add acceptance test for volume data source * create account resource * implement delete method in account resource * fix a typo in network offering * create user resource * create domain resource * add vpc data-source * add ip address data-source * add user data-source * add vpn connection data-source * add acceptance test for vpc data-source * add acceptance test for ipaddress data-source * add acceptance test for user data-source * fix a typo in applyNetworkOfferingFilters method of network offering data-source
4 participants
Hi @Pearl1594 and @harikrishna-patnala This PR is a continuation of PR: #34. In order to keep everything organized, I renamed the
AddInstanceDataSourcebranch toAddNewDataSources. Hence, this new PR is needed. I will close the old PR and continue adding additional data sources to this one.Issue: apache/cloudstack#6016